Is keeping photographic images for memories in an album or on a computer considered a sin?

It is permissible to take photographs out of necessity, provided they do not imitate God's creation. As for keeping pictures on devices and the like, the basic ruling is that it is not permissible except out of necessity, for fear that it may lead to veneration and glorification.